Navigation callbacks within mounted contextual router

[0nn0]

I'd like to make use of the navigation callbacks onBeforeNavigation and onNavigation within a mounted contextual router. It works fine when I add the callback to the main router, however when I use it within a contextual router mounted under another router, the callbacks don't get called.

Modified example:

var App = React.createClass({
  handleNavigation: function() {
    console.log( 'works great' );
  },
  render: function() {
    return (
      <Locations onBeforeNavigation={this.handleNavigation}>
        <Location path="/" handler={MainPage} />
        <Location path="/photos(/*)" handler={Photos} />
      </Locations>
    )
  }
})

var Photos = React.createClass({
  handleNavigation: function() {
    console.log( 'does not get triggered' );
  },
  render: function() {
    return (
      <Locations contextual onBeforeNavigation={this.handleNavigation}>
        <Location path="/" handler={AlbumPage} />
        <Location path="/:slug" handler={PhotoPage} />
      </Locations>
    )
  }
})

[ghost]

+1

[JabX]

I'm needing this also, it would be a great new feature.

[STRML]

Out of the country right now but would be happy to merge a PR with tests.
On Jan 24, 2015 1:31 AM, "Damien Frikha" notifications@github.com wrote:

I'm needing this also, it would be a great new feature.

—
Reply to this email directly or view it on GitHub
#95 (comment)
.

[STRML]

Long time coming, but this is fixed.