Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no-tls-verify #17

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Support no-tls-verify #17

merged 3 commits into from
Jun 30, 2023

Conversation

STRRL
Copy link
Owner

@STRRL STRRL commented Jun 30, 2023

close #15

Signed-off-by: STRRL <im@strrl.dev>
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #17 (49cb528) into master (7ec359a) will increase coverage by 1.44%.
The diff coverage is 84.61%.

❗ Current head 49cb528 differs from pull request most recent head b098085. Consider uploading reports for the commit b098085 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   24.61%   26.05%   +1.44%     
==========================================
  Files           9        9              
  Lines         589      614      +25     
==========================================
+ Hits          145      160      +15     
- Misses        436      444       +8     
- Partials        8       10       +2     
Impacted Files Coverage Δ
pkg/controller/ingress-controller.go 0.00% <0.00%> (-4.03%) ⬇️
pkg/controller/transform.go 75.58% <81.48%> (-3.00%) ⬇️
pkg/cloudflare-controller/transform.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@STRRL STRRL changed the title feat: enable no-tls-verify on https stream by default Support no-tls-verify Jun 30, 2023
Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL marked this pull request as ready for review June 30, 2023 11:05
Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL merged commit b1ff094 into master Jun 30, 2023
inductor pushed a commit to outductor/cloudflare-tunnel-ingress-controller that referenced this pull request Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No TLS Verify
2 participants