Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ARM docker image build #45

Merged
merged 4 commits into from
Nov 25, 2023
Merged

feat: add ARM docker image build #45

merged 4 commits into from
Nov 25, 2023

Conversation

kanya-approve
Copy link
Contributor

@kanya-approve kanya-approve commented Sep 26, 2023 •
edited
Loading

Addresses #34

Changes made:

  • Add TARGETARCH to Dockerfile and Makefile
  • Changed as to AS in Dockerfile
  • Added updated image build using existing Github actions
  • Ran YAML format on updated Github action

@kanya-approve kanya-approve mentioned this pull request Sep 26, 2023
Closed
@kanya-approve kanya-approve changed the title Add ARM docker image build feat: add ARM docker image build Sep 27, 2023
@kanya-approve
Copy link
Contributor Author

@STRRL - could this be merged in?

@STRRL
Copy link
Owner

STRRL commented Oct 10, 2023

@STRRL - could this be merged in?

oh hi! I would take a look soon!

@STRRL STRRL merged commit c3f8ee5 into STRRL:master Nov 25, 2023
inductor pushed a commit to outductor/cloudflare-tunnel-ingress-controller that referenced this pull request Dec 17, 2023
@kanya-approve
feat: add ARM docker image build (STRRL#45)
aae69e3 
* style: as -> AS in Dockerfile

* feat: add TARGETARCH for go build

* feat: use Github action for docker image build

* chore: add default TARGETARCH=amd64 for Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRRL STRRL STRRL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanya-approve @STRRL