Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core/java/android/provider/Settings.java #2

Closed
wants to merge 1 commit into from
Closed

Update core/java/android/provider/Settings.java #2

wants to merge 1 commit into from

Conversation

jsnweitzel
Copy link

No description provided.

@Hashcode
Copy link
Member

Hashcode commented Jan 9, 2013

Closing old requests, please re-submit if this is current.

@Hashcode Hashcode closed this Jan 9, 2013
Hashcode pushed a commit that referenced this pull request Jan 22, 2013
This commit cleans up the AlarmTile class by removing the unnecessary
listener on the alarm intent. It now listens only to the next alarm
setting value, which was fetched after receiving the intent anyway.

These changes also fix a bug that would cause the tile to not show up
after some actions, like reordering the tiles due to the visibility not
being set on tile creation.

Lastly, some minor code styling issues have been fixed.

Patch set #2: collapse onNextAlarmChanged into onChangeUri, remove
mEnabled, use TextUtils to check for string emptiness and mark
updateQuickSettings explicitly as public.

Change-Id: Ic5871a9cc4874f33181dfac14e25a89499c182f2
dhacker29 pushed a commit that referenced this pull request Feb 7, 2013
patch #2 - fixed typos
patch #3 - some fixes and translated unintentionally untranslated
  strings

Change-Id: I288bf43a027286c4c08f2a7761fc2bc19b77f04c
dhacker29 pushed a commit that referenced this pull request Feb 7, 2013
Creates an action useable by NavBar & NavRing to toggle
between most recent apps.  Will try to ignore the launcher
when possible.  ie, if you've just rebooted and have not opened any
apps, it will do nothing.  if you open 1 app, it will toggle between
that 1 app and the launcher.  Once two apps have been opened, it will
toggle between those two apps.
It's kind of like opening recents and hitting your #2 slot repeatedly

PS 2:  Add Icons from Hoolm.  {Thanks!}
       Re-wrote the logic for selecting next app.  Rather than
toggling back to launcher if only 1 app open, it does nothing.
toggling only occurs now when there are at least two apps open.
One issue that I still need to work out is that 'Recents' is somehow
showing up as a valid target to toggle to.  It shouldn't.

ps 3:  getRunningTasks() does not filter out 'Excludefromrecents'.
Thus we need checks for 'default launcher' and SystemUI.
as I write this, I realize I might be able to query the
ExcludeFromRecents flag of the package a bit more easily.

ps 4: Whitespace fix.
ps 5: one more whitespace fix.
ps 6: remove unnecessary dependency

Signed-off-by: Zaphod <mwilson@acesappraisal.com>
Change-Id: I0b59121b07b9ba44a2837a8db0266441ed82f9a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants