Devops-XXX - Ddev config update #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pookmish
requested changes
Jan 9, 2024
mdyoung3
changed the title
pookmish
reviewed
Jan 10, 2024
pookmish
reviewed
Jan 10, 2024
Comment on lines
165
to
169
| foreach($additionalSettingsFiles as $additionalSettingsFile) { | ||
| if(file_exists($additionalSettingsFile)){ | ||
| require $additionalSettingsFile; | ||
| } | ||
| } |
There was a problem hiding this comment.
Need correct spacing now.
Suggested change
| foreach($additionalSettingsFiles as $additionalSettingsFile) { | |
| if(file_exists($additionalSettingsFile)){ | |
| require $additionalSettingsFile; | |
| } | |
| } | |
| foreach ($additionalSettingsFiles as $additionalSettingsFile) { | |
| if (file_exists($additionalSettingsFile)) { | |
| require $additionalSettingsFile; | |
| } | |
| } |
There was a problem hiding this comment.
@pookmish Oops. Okay. it's standardized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Ddev updates for php 8.2 and tweaks for ease of development.
Review By (Date)
Jan 14