This repository has been archived by the owner on Mar 18, 2022. It is now read-only.
Minor fixes and suggestions. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherakama
commented
Feb 17, 2021
|
|
||
| /** | ||
| * Button Component | ||
| * | ||
| * HTML button element | ||
| */ | ||
| export const Button = ({ className, children, onClick, ref, ...props }) => { | ||
| export const Button = ({ className, children, onClick, ref, variant, size, type, isDisabled, ...props }) => { |
There was a problem hiding this comment.
If you destructure each of the levers in the constructor you can keep the {...props} on the button HTML element which might come in handy. If you don't destructure the props arg then you can't use {...props} on the HTML element as React doesn't know what to do with props like isDisabled: bool
sherakama
commented
Feb 17, 2021
Comment on lines
+51
to
+52
| default: | ||
| levers.size = classnames('su-px-26 su-py-10 su-text-20'); |
There was a problem hiding this comment.
Moved default to the default so you don't have to pass in the keyword default.
sherakama
commented
Feb 17, 2021
sherakama
commented
Feb 17, 2021
Co-authored-by: Sherakama <sherakama@gmail.com>
Co-authored-by: Sherakama <sherakama@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW