Change order of ipv4_to_ipv6 arguments #228
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
- Coverage 63.78% 59.41% -4.37%
===========================================
Files 63 61 -2
Lines 6627 6180 -447
===========================================
- Hits 4227 3672 -555
- Misses 2400 2508 +108
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Putting this into draft status, as our team keeps changing their minds about how this function should ultimately work. Will get back to a proper PR once our design is (hopefully) stabilized |
As pointed out by our core CNaaS team, the argument order of the filter function was confusing, as the filter would normally be used in Jinja templates by piping a host's IPv4 address through the filter.
The requirements keep changing back and forth, but apparently, it was still important that the resulting IPv6 address was somewhat human-readably similar to the original IPv4 address. Also, it isn't always necessary to keep the full IPv4 address inside the IPv6 address. Mostly, the host address from the IPv4 subnetwork should be readable as the same on the corresponding IPV6 subnetwork, so an option to keep only a number of IPv4 octets in the result was added.
lunkwill42
force-pushed
the
uninett.feature.fix_ipv4_to_ipv6_filter
branch
from
14f8734
to
dc7d90d
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by our core CNaaS team, the argument order of the ipv4_to_ipv6 filter function was confusing, as the filter would normally be used in Jinja templates by piping a host's IPv4 address through the filter.