Adjust form labels according to text in story

See: https://www.pivotaltracker.com/story/show/187515050

src/Surfnet/ServiceProviderDashboard/Domain/Entity/Entity/Coin.php

@@ -25,10 +25,11 @@
 use Surfnet\ServiceProviderDashboard\Domain\ValueObject\TypeOfServiceCollection;
 use Webmozart\Assert\Assert;
 
+/**
+ * @SuppressWarnings(PHPMD.ExcessiveParameterList)
+ */
 class Coin implements Comparable
 {
-
-
  public static function fromApiResponse(array $metaDataFields): self
  {
  $signatureMethod = $metaDataFields['coin:signature_method'] ?? '';

src/Surfnet/ServiceProviderDashboard/Infrastructure/DashboardBundle/Form/Entity/OidcngEntityType.php

@@ -190,6 +190,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
  CheckboxType::class,
  [
  'required' => false,
+ 'label' => 'entity.edit.label.isPublicOnDashboard',
  'attr' => [
  'required' => false,
  'data-help' => 'entity.edit.information.isPublicOnDashboard',

src/Surfnet/ServiceProviderDashboard/Infrastructure/DashboardBundle/Form/Entity/SamlEntityType.php

@@ -171,6 +171,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
  'isPublicInDashboard',
  CheckboxType::class,
  [
+ 'label' => 'entity.edit.label.isPublicOnDashboard',
  'required' => false,
  'attr' => [
  'required' => false,

src/Surfnet/ServiceProviderDashboard/Infrastructure/DashboardBundle/Resources/translations/messages.en.yml

@@ -267,7 +267,8 @@ entity.edit.information.accessTokenValidity: Text should be set in web translati
 entity.edit.information.resourceServers: Text should be set in web translations
 entity.edit.information.redirectUrls: Text should be set in web translations
 entity.edit.information.isPublicClient: Text should be set in web translations
-entity.edit.information.isPublicOnDashboard: Text should be set in web translations
+entity.edit.label.isPublicOnDashboard: Make your service publicly visible in the SURFconext dashboard
+entity.edit.information.isPublicOnDashboard: The SURFconext dashboard shows institutions a list of applications that are connected to SURFconext. If you tick the checkbox, your application will be visible to everyone, and instutions can request to connect. Leave the checkbox unticked if you have an application that is for one institution only and you do not want other institutions to be able to log in to your application as well.
 entity.edit.information.pastedMetadata: Text should be set in web translations
 entity.edit.information.logoUrl: Text should be set in web translations
 entity.edit.information.nameNl: Text should be set in web translations

tests/unit/Domain/Entity/Entity/MetaDataTest.php

@@ -241,7 +241,7 @@ private function metaData(string $mode)
  $contactList = m::mock(ContactList::class);
  $contactList->shouldReceive('merge');
 
- $coin = m::mock(Coin::class, [null, null, null, null, null, null, null, null, null]);
+ $coin = m::mock(Coin::class, [null, null, null, null, null, null, null, null, null, null]);
  $coin->shouldReceive('merge');
 
  $logo = m::mock(Logo::class);

tests/unit/Domain/Service/ContractualBaseServiceTest.php

@@ -107,7 +107,7 @@ private function createMockEntity(string $environment, string $protocolValue, st
  {
  $metadata = $this->createMock(MetaData::class);
  // Use an acutal Coin instance, as the value for the contractual base is overwritten in the service
- $coin = new Coin(null, null, null, null, null, null, null, null, null);
+ $coin = new Coin(null, null, null, null, null, null, null, null, null, null);
  $service = $this->createMock(Service::class);
  $protocol = $this->createMock(Protocol::class);
  $protocol->method('getProtocol')->willReturn($protocolValue);