Correctly publish OIDC redirectUris to Manage

The array that is passed along to manage should be a list, not a map.
If the php indexes are updated along the way, by adding/removing items
from the form. The index order might not be sequentially pristine. This
causes JSON encode to generate a map instead of a list.

By resetting the list before publishing, this problem should be remedied

https://www.pivotaltracker.com/story/show/163646662

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## Next release
 
+**Bugfix**
+ - Correctly publish OIDC redirect URIs to Manage #233
 
 ## 2.0.3
 

src/Surfnet/ServiceProviderDashboard/Application/Metadata/JsonGenerator.php

@@ -267,7 +267,8 @@ private function generateOidcClient(Entity $entity)
  {
  $metadata['clientId'] = str_replace('://', '@//', $entity->getEntityId());
  $metadata['clientSecret'] = $entity->getClientSecret();
- $metadata['redirectUris'] = $entity->getRedirectUris();
+ // Reset the redirect URI list in order to get a correct JSON formatting (See #163646662)
+ $metadata['redirectUris'] = array_values($entity->getRedirectUris());
  $metadata['grantType'] = $entity->getGrantType()->getGrantType();
  $metadata['scope'] = ['openid'];
 

tests/unit/Application/Metadata/JsonGeneratorTest.php

@@ -467,10 +467,10 @@ public function test_it_can_build_oidc_entity_data_for_new_entities()
  'clientSecret' => 'test',
  'redirectUris' =>
  array (
- 0 => 'uri1',
- 1 => 'uri2',
- 2 => 'uri3',
- 3 => 'http://playground-test',
+ 'uri1',
+ 'uri2',
+ 'uri3',
+ 'http://playground-test',
  ),
  'grantType' => 'implicit',
  'scope' =>
@@ -537,8 +537,8 @@ public function test_it_can_build_oidc_data_for_existing_entities()
  'redirectUris' =>
  array (
  0 => 'uri1',
- 1 => 'uri2',
- 2 => 'uri3',
+ 8 => 'uri2',
+ 4 => 'uri3',
  3 => 'http://playground-test',
  ),
  'grantType' => 'implicit',