Fix oidc client id on detail page #229
Conversation
The : in an oidc entityId should be replaced with a @. This was done on other pages except on the entity detail page were it was missing in the corresponding viewobject. https://www.pivotaltracker.com/story/show/163417371
| @@ -323,7 +323,10 @@ public function getAcsLocation() | |||
| */ | |||
| public function getEntityId() | |||
| { | |||
| return $this->entityId; | |||
| if ($this->getProtocol() !== DomainEntity::TYPE_OPENID_CONNECT) { | |||
There was a problem hiding this comment.
Still not completely sold on the str_replace '://', '@//' occurrences popping up in the code in several places. What bothers me the most is that this is not really semantically sound. You are not getting an entity id, but a client id.
As this is just cosmetically, we could think about making a Twig filter that displays the entity id as a client id.
Feel free to postpone this change for now, but it just doesn't sit right with me.
There was a problem hiding this comment.
I agree this is not the best solution. However it is a lso not a clientId because when an OIDC entity is a draft the clientId is the entityId, only after it's pushed to manage it's replaced. I think the the current solution will be sufficient becasue it should be a temporary solution.
The : in an oidc entityId should be replaced with a @. This was done
on other pages except on the entity detail page were it was missing in
the corresponding viewobject.
https://www.pivotaltracker.com/story/show/163417371