Update the production connection status on publication #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a test should be a valuable addition. Also we should maybe look into a state engine of some sort later on to keep the PublishEntity*CommandHandlers maintainable. The latter is a suggestion we could very well address later on. |
The status was not updated on the Service entity, The first time when the status is not yet set to either requested or active, the status is updated. https://www.pivotaltracker.com/story/show/163732191
MKodde
force-pushed
the
feature/update-service-status-on-entity-publication
branch
from
e85a6a2
to
fa86eba
Compare
|
Yes, some handlers are growing and growing. I'm putting a todo on my list to create a TD ticket for this. I also fixed the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status was not updated on the Service entity, The first time when
the status is not yet set to either requested or active, the status
is updated.
https://www.pivotaltracker.com/story/show/163732191