Change detailed route on overview page to prevent 403 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
reviewed
Feb 21, 2019
app/config/parameters.yml.dist
Outdated
| @@ -52,7 +52,7 @@ parameters: | |||
| manage_prod_host: 'https://manage-prod.dev.support.surfconext.nl' | |||
| manage_prod_username: sp-dashboard | |||
| manage_prod_password: secret | |||
| manage_prod_publication_status_create: prodaccepted | |||
| manage_prod_publication_status_create: notprodaccepted | |||
| @@ -300,6 +300,8 @@ public function adminOverviewAction($serviceId) | |||
| $entityList = $this->entityService->getEntityListForService($service); | |||
| $serviceList = new ServiceList([Service::fromService($service, $entityList, $this->router)]); | |||
|
|
|||
| echo $service->getTeamName(); | |||
Change route on overview page for non admins to the entity detail page. This should be changed because the currently used route should not be accessible for non admins. This in order to prevent an exception when trying to access the edit page for non admins when not allowed.
pablothedude
force-pushed
the
feature/change-overview-detailed-route
branch
from
4a32281
to
916f18e
Compare
|
No didn't forget to commit |
|
Thanks for the fix, to prevent future regression, I've added a web test covering this behavior, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change route on overview page for non admins to the entity detail
page. This should be changed because the currently used route should
not be accessible for non admins. This in order to prevent an exception
when trying to access the edit page for non admins when not allowed.