Add translatable footer links #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contact and privacy links where set to a hard '/'. This is addressed by setting adding them to the translations. Allowing overriding these URL's from the web translation interface. Some dummy defaults are set in the messages.en.yml. See: https://www.pivotaltracker.com/story/show/165965469
app/Resources/views/base.html.twig
Outdated
| @@ -51,8 +51,8 @@ | |||
| </div> | |||
| <div class="footer"> | |||
| <div class="footer-inner"> | |||
| <span><a href="/" target="_blank">{{ 'page.header.privacy'|trans }}</a></span> | |||
| <span><a href="/" target="_blank">{{ 'page.header.contact'|trans }}</a></span> | |||
| <span><a href="{{ 'page.footer.privacy_link'|trans }}" target="_blank">{{ 'page.header.privacy'|trans }}</a></span> | |||
There was a problem hiding this comment.
Is the header/footer mismatch in the name deliberate?
There was a problem hiding this comment.
Added the translation to prevent regressions in the future
Add separate translations for the footer links to prevent regressions in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
contactandprivacylinks were set to a hard '/'. This is addressed by setting adding them to the translations. Allowing overriding these URL's from the web translation interface. Some dummy defaults are set in the messages.en.yml.See: https://www.pivotaltracker.com/story/show/165965469