Show OIDC items on entity details #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the entity protocol is oidc, the oidc attributes are shown on the entity detail screen. This entails: 1. A list of the redirect uris (new: list field) 2. The grant type (text field) 3. Playground enabled (new: boolean field) The field labels are being made into translatable messages. They are key -> translation: - entity.detail.metadata.redirect_uris: Redirect URIs - entity.detail.metadata.grant_type: Grant type - entity.detail.metadata.playground_enabled: Playground enabled? See: https://www.pivotaltracker.com/story/show/164598856
MKodde
force-pushed
the
bugfix/show-oidc-entity-details
branch
from
f4ac6b7
to
a056fae
Compare
| @@ -29,6 +29,9 @@ entity: | |||
| metadata_url: Metadata URL | |||
| acs_location: ACS location | |||
| entity_id: Entity ID | |||
| grant_type: Grant type | |||
| redirect_uris: Redirect URIs | |||
| playground_enabled: Playground enabled? | |||
There was a problem hiding this comment.
I'm wondering; why only here a question mark?
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the entity protocol is oidc, the oidc attributes are shown on the entity detail screen. This entails:
The field labels are being made into translatable messages. They are key -> translation:
See: https://www.pivotaltracker.com/story/show/164598856