Symfony 5 upgrade #565
Merged
Symfony 5 upgrade #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaky212
force-pushed
the
feature/symfony-5-upgrade-continued
branch
from
42b6639
to
84023f9
Compare
Shaky212
force-pushed
the
feature/symfony-5-upgrade
branch
11 times, most recently
from
3a2b53f
to
859978a
Compare
Shaky212
force-pushed
the
feature/symfony-5-upgrade-continued
branch
from
84023f9
to
53845dc
Compare
MKodde
force-pushed
the
feature/symfony-5-upgrade-continued
branch
from
53845dc
to
a152117
Compare
Closed
MKodde
force-pushed
the
feature/symfony-5-upgrade-continued
branch
from
5abd989
to
03f7d96
Compare
MKodde
force-pushed
the
feature/symfony-5-upgrade-continued
branch
5 times, most recently
from
a4adf2c
to
9c7ab01
Compare
quartje
force-pushed
the
feature/symfony-5-upgrade-continued
branch
2 times, most recently
from
8f62fc1
to
4e01151
Compare
MKodde
reviewed
Jan 18, 2023
There was a problem hiding this comment.
What an effort! Hats off to you @Shaky212
See some feedback that you might need to do something with, but at the other hand. Might also want to fix in a successive PR. You be the judge.
For now, we should first get a 4.4 release before merging this to develop.
Shaky212
force-pushed
the
feature/symfony-5-upgrade-continued
branch
from
4d5a356
to
63891df
Compare
MKodde
reviewed
Jan 23, 2023
composer.json
Outdated
| "assets:install %PUBLIC_DIR%": "symfony-cmd" | ||
| }, | ||
| "symfony-scripts": [ | ||
| "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters", |
There was a problem hiding this comment.
This Symfony script will not work anymore as we removed the parameters handler dependency.
composer.json
Outdated
Comment on lines
87
to
89
| "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache", | ||
| "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installAssets", | ||
| "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installRequirementsFile" |
There was a problem hiding this comment.
Same for the DistributionBundle scripts. Output of composer install
Class Incenteev\ParameterHandler\ScriptHandler is not autoloadable, can not call symfony-scripts script
Class Sensio\Bundle\DistributionBundle\Composer\ScriptHandler is not autoloadable, can not call symfony-scripts script
Class Sensio\Bundle\DistributionBundle\Composer\ScriptHandler is not autoloadable, can not call symfony-scripts script
Class Sensio\Bundle\DistributionBundle\Composer\ScriptHandler is not autoloadable, can not call symfony-scripts script
composer.json
Outdated
Comment on lines
152
to
158
| "symfony-app-dir": "app", | ||
| "symfony-bin-dir": "bin", | ||
| "symfony-var-dir": "var", | ||
| "symfony-web-dir": "web", | ||
| "symfony-tests-dir": "tests", | ||
| "symfony-assets-install": "relative", | ||
| "branch-alias": null |
Upgrade Symfony 4 Upgrade Symfony 4
Different situations are covered when creating and changing entities. These include creating an entity, whether or not based on a copy, or editing an existing entity. In addition, the environment is decisive: test, production or otherwise In case of a new (copy) entity, a connection request must also be submitted. These situations and error handling are now a bit more streamlined.
The SAML bundle is now capable of running and evaluating SAML authentication requests (and SAML responses). This commit removes the old logic that was hard coded into the SP Dashboard, and integrates the new authentication system from the Stepup saml bundle.
The previous lifetime guard solution was dropped in favor of using the SF built in session lifetime features.
This is now (as of SF5) managed using .env vars that determine the env + debug mode from the .env vars.
Some of the code using the code needed some changes as some of the methods where changed slightly
Shaky212
force-pushed
the
feature/symfony-5-upgrade-continued
branch
from
9975792
to
c0acecd
Compare
Shaky212
force-pushed
the
feature/symfony-5-upgrade-continued
branch
from
79deccc
to
e799cda
Compare
MKodde
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mighty PR where multiple disciplines entailing the Symfony upgrade come together.
Among them:
#562 Upgrade to Symfony 4 (in preparation to this SF5 upgrade)
#571 Move to Github actions for test integrations
At first these tasks where created separate. But to keep things more tight, I chose to merge/rebase them into this branch.