Introduce new privacy questions #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/introduce-new-privacy-questions
branch
5 times, most recently
from
c311794
to
7ade1a1
Compare
Base automatically changed from
feature/remove-unused-privacy-questions
to
develop
June 28, 2023 08:28
MKodde
force-pushed
the
feature/introduce-new-privacy-questions
branch
from
7ade1a1
to
1a75d54
Compare
MKodde
requested review from
rubencatshoek and
pablothedude
and removed request for
rubencatshoek
pablothedude
approved these changes
Jul 4, 2023
| */ | ||
| class DpaType | ||
| { | ||
| public const DPA_TYPE_NOT_APPLICABLE = 'dpa_not_applicable'; |
There was a problem hiding this comment.
Do all those constant have to be public?
There was a problem hiding this comment.
Good point, only the default was used outside of the VO scope.
Updated
| @@ -68,6 +69,18 @@ class PrivacyQuestionsCommand implements Command | |||
| */ | |||
| private $otherInfo; | |||
|
|
|||
| private DpaType $dpaType; | |||
There was a problem hiding this comment.
No assertion is needed here?
There was a problem hiding this comment.
Good point, I've added a NotBlank and Type assertion. Thanks for spotting that!
MKodde
force-pushed
the
feature/introduce-new-privacy-questions
branch
from
a303313
to
fd21189
Compare
- New questions where added (dpatype + privacy policy url NL/EN) - When saving an exisiting entity, also include the privacy questions. To achieve that goal, the priv. questions generator had to be called explicitly for the different entity type json generators.
MKodde
force-pushed
the
feature/introduce-new-privacy-questions
branch
from
fd21189
to
ae4616c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PART 2 of the Privacy Questions overhaul
In the second part, I added the new fields. Which are the
dpaTypeand the multilingualPrivacyStatementUrl(nl+en) fields. They are added throughout the entire stack.While at it, I found out the Privacy Questions where not included upon entity update actions. That was also addressed in this PR.