Push test metadata upon entity deletion #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/push-after-delete
branch
from
53c222a
to
7789466
Compare
MKodde
force-pushed
the
feature/push-after-delete
branch
3 times, most recently
from
d2591c3
to
2997521
Compare
rubencatshoek
approved these changes
Jul 4, 2023
| @@ -58,5 +60,8 @@ public function handle(DeletePublishedTestEntityCommand $command) | |||
| if ($response !== DeleteManageEntityRepository::RESULT_SUCCESS) { | |||
| throw new EntityNotDeletedException('Deleting the entity yielded an non success response'); | |||
There was a problem hiding this comment.
Suggested change
| throw new EntityNotDeletedException('Deleting the entity yielded an non success response'); | |
| throw new EntityNotDeletedException('Deleting the entity yielded a non success response'); |
MKodde
force-pushed
the
feature/push-after-delete
branch
from
2997521
to
ae2325f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test entity is removed from manage, also push the updated metadata to EngineBlock and the OidcNg gateway.
https://www.pivotaltracker.com/story/show/184915015