Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mixup of DPA_TYPE_MODEL_SURF and DPA_TYPE_IN_SURF_AGREEMENT #614

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

quartje
Copy link
Contributor

@quartje quartje commented Oct 10, 2023

We have fixed this in production by changing the translations. Better to fix this in code

@quartje quartje requested a review from MKodde October 10, 2023 19:23
Copy link
Contributor

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking at the key-value pairs they seem to make sense. By changing this up like you propose I'm losing this association.

This might need to be changed at another point in the code? Or maybe in translations?

Of maybe, most probably, I'm missing the point?

@quartje
Copy link
Contributor Author

quartje commented Apr 10, 2024

When looking at the key-value pairs they seem to make sense. By changing this up like you propose I'm losing this association.

This might need to be changed at another point in the code? Or maybe in translations?

Of maybe, most probably, I'm missing the point?

You are completely right of course. That'll teach me trying to change code :)

It was the default translation that was mixed up. I've reworked the PR to change the translations in stead!

@MKodde MKodde merged commit d005ab5 into main Apr 11, 2024
2 checks passed
@MKodde MKodde deleted the bugfix/dpa_type_mixup branch May 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants