Show correct menu items according to the granted authorizations #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 17th of July it was possible to both be SurfConextResponsible AND have a regular ROLE_USER at the same time. This was already correctly handled by the Authz logic, but the menu did not yet show the correct menu items for the roles the user is authorized for.. That's what fixed here. At first I thought the SamlProvider was broken, hence the (cosmetic) change in the Test. See: https://www.pivotaltracker.com/story/show/186881796/comments/242257534
MKodde
changed the title
|
Bart functionally reviewed this. Given the simple nature of this PR.. Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 17th of July it was possible to both be SurfConextResponsible AND have a regular ROLE_USER at the same time. This was already correctly handled by the Authz logic, but the menu did not yet show the correct menu items for the roles the user is authorized for..
That's what fixed here. At first I thought the SamlProvider was broken, hence the (cosmetic) change in the Test.
See: https://www.pivotaltracker.com/story/show/186881796/comments/242257534