Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflows: Bootstrap first, then start spdashboard #675

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

quartje
Copy link
Contributor

@quartje quartje commented Aug 26, 2024

No description provided.

@quartje quartje force-pushed the bugfix/fix_tests_order branch 2 times, most recently from 3473c67 to d20a284 Compare August 27, 2024 07:06
@MKodde MKodde self-requested a review August 27, 2024 11:57
Copy link
Contributor

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be ahead of the game.. But reviewing your changes (which look great by the way) I noticed that the new strategy to run the tests as 33:33 (www-data) is causing the app to not be able to write to the readonly the database

quartje and others added 5 commits August 29, 2024 10:48
And stop injecting it on the Fetcher. This caused metadat import to
500..
Some tests had not run since the 6.2 features were added. That new
behavior caused existing tests to fail. That was fixed in this commit
@MKodde
Copy link
Contributor

MKodde commented Aug 29, 2024

@quartje I removed the change to the .env.test and added some fixes for the webtests.

@MKodde MKodde merged commit 6aee560 into main Aug 29, 2024
2 of 3 checks passed
@MKodde MKodde deleted the bugfix/fix_tests_order branch August 29, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants