Remove usage of getimagesize #679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not use the url_fopen portion of the getimagesize function. This is the case when you use getimagesize with a remote file location. 1. For the ValidLogoValidator: We can exclusively use the curl based validation (already implemented in the CurlLogoValidationHelper 2. The message sent to Manage does not require a valid with and height to be set, as they will be esteablished on the logo 'cdn' See: https://www.pivotaltracker.com/n/projects/1400064/stories/186921877
MKodde
force-pushed
the
feature/logo-metadata-improvement
branch
from
c9759fd
to
218d33d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can not use the url_fopen portion of the getimagesize function. This is the case when you use getimagesize with a remote file location.
See: https://www.pivotaltracker.com/n/projects/1400064/stories/186921877