Publish production entity #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/publication-of-production-entity
branch
4 times, most recently
from
3bdf2f1
to
1f775d3
Compare
jorissteyn
reviewed
Nov 3, 2017
|
|
||
| return $this->redirectToRoute('service_published'); | ||
| } | ||
| return $this->publishEnity($entity, $flashBag); |
MKodde
force-pushed
the
feature/publication-of-production-entity
branch
from
d44a669
to
eb69d97
Compare
For now the Publishing of entities where always aimed at the test env. In the upcomming changes, the entities can also be published to production. To facilitate this change, the current name of the publish command/handler and tests where misleading. And have been change to more clearly indicate the test environment is being targeted.
The entity needs to be set to published when a production entity has been published.
- A new command was introduced to cover the publication to production - The command is handled by a new command handler - This command handler sends the confirmation mail and sets the entity status to 'published' - The Entity edit controller is tasked with creating the correct mail message that is sent with the publish command - The published thank you actions have been moved to their own controller. - A new web test was added to test the production publish flow also verifying the sending of the publishing request mail
An edit of a published production form is a valid action in the sp dashboard. To facilitate this, the entity status is reset to draft before editing it.
Additional information is passed along in the production request message to servicedesk.
MKodde
force-pushed
the
feature/publication-of-production-entity
branch
from
eb69d97
to
59382c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review notes
A database migration was added.
Todo
Checklist