Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first GHA #14

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Add first GHA #14

merged 3 commits into from
Mar 19, 2024

Conversation

parijke
Copy link
Contributor

@parijke parijke commented Mar 19, 2024

Basic GHA checks

@parijke parijke requested a review from MKodde March 19, 2024 08:53
Copy link
Contributor

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step!

Did you intentionally wait with implementing the other QA tools? Have a look at the build.xml for details on the other tooling we used to run and their config details.

@parijke
Copy link
Contributor Author

parijke commented Mar 19, 2024

Great first step!

Did you intentionally wait with implementing the other QA tools? Have a look at the build.xml for details on the other tooling we used to run and their config details.

@MKodde Yes, since this is such a small library and used as a dependency in a much bugger complex system, I want it up-to-date for now.

I am not sure what the build.xml is about.

@parijke parijke closed this Mar 19, 2024
@parijke parijke reopened this Mar 19, 2024
@parijke parijke merged commit a15b900 into develop Mar 19, 2024
2 of 3 checks passed
@MKodde
Copy link
Contributor

MKodde commented Mar 19, 2024

The build.xml is what used to run the QA tests. PHPCS, PHPMD, Linting tools. They are going to 'waste' now. Please add them back in a successive PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants