Temporarily increase timeouts #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
reviewed
Nov 13, 2024
dirkmueller
reviewed
Nov 13, 2024
dirkmueller
reviewed
Nov 13, 2024
tests/test_postgres.py
Outdated
| @@ -87,6 +88,9 @@ def test_postgres_db_env_vars( | |||
| pg_user: Optional[str], | |||
| password: str, | |||
| username: Optional[str], | |||
| healthcheck_timeout: timedelta( | |||
| seconds=180 | |||
| ), # FIXME https://github.com/SUSE/BCI-tests/issues/647 | |||
There was a problem hiding this comment.
Suggested change
| ), # FIXME https://github.com/SUSE/BCI-tests/issues/647 | |
| ) if LOCALHOST.system_info.arch == "ppc64le" else None , # FIXME https://github.com/SUSE/BCI-tests/issues/647 |
There was a problem hiding this comment.
Please check again @dirkmueller , this was the wrong place for the healthcheck_timeout and in the outer scope LOCALHOST is not available.
There was a problem hiding this comment.
well, you need to import it .. I'll push a followup commit
Increase the timeouts for container startup temporarily due to the need of using emulated ppc workers.
dirkmueller
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the timeouts for container startup temporarily due to the need of using emulated ppc workers.
[CI:TOXENVS] postgres,mariadb