[go] extract helm version from go.mod to skip too old go versions #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
force-pushed
the
helm-generic-skipping
branch
from
e521770 to
8df435b
Compare
dirkmueller
reviewed
Jan 8, 2025
|
|
||
| if required_go_version > go_version: | ||
| pytest.skip( | ||
| f"Helm requires Go >= {required_go_version}, but we have {go_version}" |
There was a problem hiding this comment.
we're pinning a specific helm release, we know which go versions are supported or not supported.
There was a problem hiding this comment.
Thank you for the helpful feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CI:TOXENVS] go
This should allow us to stop worrying about outdated go versions