This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Moved customizable env variables to .env file #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssola
suggested changes
Aug 3, 2017
|
|
||
| # Since we have no nginx in insecure mode, portus have to | ||
| # serve the static files | ||
| RAILS_SERVE_STATIC_FILES: 'true' |
There was a problem hiding this comment.
Why have you turned this into a string ? Same in the other file
|
It is due to a quirk in the yaml file. YAML file by default will turn a set of boolean value into "True"/"False", and docker-compose will warn (and possibly error) if there is a boolean value in the YAML. See docker/compose#1788 It was okay previous because the environment variables was passed in as an array of environmental strings, which gets interpreted directly. The issue arises when we use the object syntax to pass in env variables. PS: I realized that I've missed out changing |
Signed-off-by: Soedarsono <soedar.sg@gmail.com>
|
Thanks for taking care of this 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1360