Check generated code for IBT compatibilty #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some kernel versions do not support IBT. Check if we have such cases and emit a runtime error if found. Signed-off-by: Giuliano Belinassi <gbelinassi@suse.de>
marcosps
reviewed
Jun 7, 2024
| @@ -460,6 +460,16 @@ class FunctionExternalizerPass : public Pass | |||
| ClangCompat_None, ctx->OFS); | |||
| PrettyPrint::Set_Source_Manager(&ctx->AST->getSourceManager()); | |||
|
|
|||
| if (ctx->Ibt && ctx->AST) { | |||
There was a problem hiding this comment.
Maybe also check here is Kernel was set? Maybe we should only set Ibt is Kernel was set in the first place...
|
Either way it worked as expected! 🚢 it! |
It is possible that we need to emit the #include <linux/livepatch.h> even before the main file, for example if the header is passed through -include header.h. Signed-off-by: Giuliano Belinassi <gbelinassi@suse.de>
giulianobelinassi
force-pushed
the
ibt_check
branch
from
64c77a2 to
3dca9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some kernel versions do not support IBT. Check if we have such cases and emit a runtime error if found.