Turned style guide into book #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariavladykina
requested review from
jfaltenbacher,
tomschr,
janajaeger,
cwickert and
PadraigDillon1
tomschr
requested changes
May 17, 2024
There was a problem hiding this comment.
@dariavladykina Thanks Daria, this looks great! 👍 There is only a minor issue in the DOCTYPE, see below.
janajaeger
approved these changes
May 22, 2024
jfaltenbacher
approved these changes
May 22, 2024
PadraigDillon1
approved these changes
May 22, 2024
|
@dariavladykina I found two files which the wrong DOCTYPE. I fixed it in commit 05e97a4. Other than that, it looks great! 👍 |
tomschr
approved these changes
May 22, 2024
|
Thank you very much @tomschr for all your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @tomschr 's kind help, the style guide was turned into a book (structurally) and now enjoys the 3-column layout with subsections (which we have a lot) well seen on the right.