Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New section for activity log #179

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

abravosuse
Copy link
Collaborator

This PR isto be reviewed ahead of the release of version 2.4. But it is not to be merged/published until the new version is out.

It delivers a new section for the Activity Log that will be available with the new version.

The new section should be located after the also new SSO integration section and before the section about performing configuration checks.

@abravosuse abravosuse added the prj:Trento Related to Trento documentation label Oct 16, 2024
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
@abravosuse
Copy link
Collaborator Author

Thanks for your suggestions @balanza . I think I have addressed them in my last commit. Please review and let me know if it's OK now.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @dmpop ! Just a couple of additional suggestions from my side.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
@abravosuse abravosuse requested a review from dmpop October 31, 2024 12:23
Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prj:Trento Related to Trento documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants