Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trento Container Installation Instructions #182

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

janvhs
Copy link
Member

@janvhs janvhs commented Oct 21, 2024

This is part of the new version if the Trento release and therefore should go
together with the other PRs by @abravosuse. I didn't see his existing PRs
before opening this one. Sorry for the confusion this might have introduced


PR creator: Description

As part of the recent updates to Trento,
we separated the Trento checks into it's own
package & repo

The separation requires updates to the container installation. This allows the
user to update the checks separately from Wanda. An update to the systemd
/ RPM instructions is not required, because Wanda pulls the newly created
RPM as part of its dependencies

I will make at least two more PRs in the following days, because I plan to remove
all references of Trento Premium from the xml file, since we finally eliminated the
open-core model 🥳 . Furthermore, I might need to update the Kubernetes
instructions. If you want I can do these together in one PR or split them, so the
workload of reviewing is more manageable :D

PR creator: Are there any relevant issues/feature requests?

I don't think so

@janvhs
Copy link
Member Author

janvhs commented Oct 22, 2024

@EMaksy this is the other PR I talked about

The command included an extra space before the passed flag.  Not
important for functionality, but this looks cleaner
The separation of the checks from Wanda into a separate package requires
updates to the container installation.  This allows the user to update
the checks separately from Wanda.  An update to the systemd / RPM
instructions is not required, because Wanda pulls the newly created RPM
as part of its dependencies
Copy link
Collaborator

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Procedure tested successfully. Thank you @janvhs !
Just one small change request: the value of ADMIN_PASSWORD is set to test1234 in the guide. Yes, it's just an example and the user should replace it with their own. But if they used it like that (maybe they are just testing the procedure), the installation would fail because the password does not adhere to the newly introduced password rules. Simply replacing test1234 with test1357 takes away that risk.

@janvhs
Copy link
Member Author

janvhs commented Oct 22, 2024

@abravosuse Sure, thanks for pointing it out and adding the others as reviewers! I somehow didn't have the rights to add them. Is that correct or something I will need to check out?

@abravosuse
Copy link
Collaborator

Sure, thanks for pointing it out and adding the others as reviewers! I somehow didn't have the rights to add them. Is that correct or something I will need to check out?

Maybe Toms needs to grant you authorization. Let's ask him when he gets back.

trento/migration/container-install.md Outdated Show resolved Hide resolved
trento/migration/container-install.md Outdated Show resolved Hide resolved
trento/migration/container-install.md Outdated Show resolved Hide resolved
trento/migration/container-install.md Outdated Show resolved Hide resolved
trento/xml/container-install.xml Outdated Show resolved Hide resolved
trento/xml/container-install.xml Outdated Show resolved Hide resolved
trento/xml/container-install.xml Outdated Show resolved Hide resolved
@abravosuse abravosuse added the prj:Trento Related to Trento documentation label Oct 25, 2024
abravosuse and others added 7 commits October 28, 2024 10:17
Replace specific version of containers with latest
Replace specific version of container images with latest
Co-authored-by: Dmitri Popov <dmpop@cameracode.coffee>
Co-authored-by: Dmitri Popov <dmpop@cameracode.coffee>
Co-authored-by: Dmitri Popov <dmpop@cameracode.coffee>
Co-authored-by: Dmitri Popov <dmpop@cameracode.coffee>
Co-authored-by: Dmitri Popov <dmpop@cameracode.coffee>
Copy link
Collaborator

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmpop just one comment from my side.

trento/migration/container-install.md Outdated Show resolved Hide resolved
@abravosuse abravosuse requested a review from dmpop October 31, 2024 12:43
Copy link
Contributor

@dmpop dmpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prj:Trento Related to Trento documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants