Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Due to an inconsistent behavior of the OBS API, multibuild variants are listed in the package results. #72

Closed
boiko opened this issue Aug 9, 2022 · 2 comments
Closed

Due to an inconsistent behavior of the OBS API, multibuild variants are listed in the package results. #72

boiko opened this issue Aug 9, 2022 · 2 comments

Comments

@boiko
Copy link
Collaborator

boiko commented Aug 9, 2022

Due to a bug in the OBS API endpoint (reported here: openSUSE/open-build-service#12925) when explicitly passing deleted=0 in the /sources/<proj> endpoint, the multibuild versions of packages are listed in the results, see this example:

> osc api /source/devel:languages:python:Factory | grep python36
  <entry name="python36"/>

Now if I append deleted=0 to the arguments, the API endpoint lists also multibuild variants:

> osc api /source/devel:languages:python:Factory?deleted=0 | grep python36
  <entry name="python36"/>
  <entry name="python36:base" originpackage="python36"/>
  <entry name="python36:doc" originpackage="python36"/>

Until this gets fixed upstream, it would be nice if osc-tiny could omit the deleted=0 from the API request.
boiko added a commit to boiko/osc-tiny that referenced this issue Aug 9, 2022
@boiko
Omit the deleted parameter if its value is 0 when listing packages
8d7a2d2 
This is to workaround an inconsistent behavion on projects that have multibuild-
enabled packages.

Closes SUSE#72
@boiko boiko mentioned this issue Aug 9, 2022
Closed
@crazyscientist
Copy link
Collaborator

I had reported this already two years ago: openSUSE/open-build-service#9715 😂

@crazyscientist
Copy link
Collaborator

Given the discussion in this original issue, I would not object to a work around in osc-tiny, but I'm afraid that there is a method to the madness and it would be nice to have a single workaround to catch them all.

crazyscientist added a commit that referenced this issue Aug 12, 2022
@crazyscientist
Handle boolean query params (fixes #72)
8b5b3e0 
The build service has a rather specific interpretation of boolean parameters:
They are flags (i.e. without value) instead of params with explicit values.

This change explicitly tries to not send values for boolean params in order to
avoid confusing API responses.
(see e.g. openSUSE/open-build-service#9715)
@boiko boiko closed this as completed in f0dadfb Aug 12, 2022
crazyscientist added a commit that referenced this issue Aug 16, 2022
@crazyscientist
Make distinction between "true" booleans and pretenders (#72)
031083f 
While the IBS API has explicit boolean parameters, it also has
parameters, which pretend to be boolean, but are not.

In order to keep client working and shield them from this madness
this is a workaround to the existing workaround (#77).
crazyscientist added a commit that referenced this issue Aug 16, 2022
@crazyscientist
Make distinction between "true" booleans and pretenders (#72) (#83)
0af0cb0 
While the IBS API has explicit boolean parameters, it also has
parameters, which pretend to be boolean, but are not.

In order to keep client working and shield them from this madness
this is a workaround to the existing workaround (#77).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit the deleted parameter if its value is 0 when listing packages boiko/osc-tiny
2 participants
@boiko @crazyscientist