Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for new OSC config #149

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Support for new OSC config #149

merged 1 commit into from
Dec 11, 2023

Conversation

crazyscientist
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

Coverage report

The coverage rate went from 76.2% to 76.1% ⬇️

0% of new lines are covered.

Diff Coverage details (click to unfold)

osctiny/utils/conf.py

0% of new lines are covered (64.77% of the complete file).
Missing lines: 202, 204, 205, 207

@der-gabe der-gabe self-assigned this Dec 11, 2023
@der-gabe
Copy link
Member

Looks reasonable enough, but can one find information on this new osc.config attribute anywhere?

@crazyscientist
Copy link
Collaborator Author

but can one find information on this new osc.config attribute anywhere?

Once the testsuite failed, I went directly to the sources of osc.

@der-gabe
Copy link
Member

OK, guess I'll have to do the same myself then...

@der-gabe
Copy link
Member

Found it. LGTM! 🙂 👍

@der-gabe der-gabe merged commit 04d772f into master Dec 11, 2023
18 checks passed
@der-gabe der-gabe deleted the new-osc-conf-format branch December 11, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@der-gabe der-gabe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazyscientist @der-gabe