Extend logging and fix missing namespace in where clause #153
Conversation
asmorodskyi
force-pushed
the
updaterun_fixing
branch
2 times, most recently
from
5bef4e7 to
b034d59
Compare
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 81.03% 80.84% -0.20%
==========================================
Files 26 26
Lines 1962 1968 +6
==========================================
+ Hits 1590 1591 +1
- Misses 372 377 +5
Continue to review full report at Codecov.
|
asmorodskyi
force-pushed
the
updaterun_fixing
branch
from
b034d59 to
0b3ada3
Compare
| o.region = i.region | ||
| if o.state == StateChoice.DELETED: | ||
| logger.error("Update already DELETED instance %s:%s\n\t%s", provider, i.instance_id, i.csp_info) | ||
| logger.error("[%s] Update already DELETED instance %s:%s %s", | ||
| namespace, provider, i.instance_id, i.all_time_fields()) | ||
| if o.state != StateChoice.DELETING: | ||
| o.state = StateChoice.ACTIVE |
There was a problem hiding this comment.
| o.state = StateChoice.ACTIVE | |
| logger.error("[%s] Update and reactivating DELETING instance %s:%s %s", | |
| namespace, provider, i.instance_id, i.all_time_fields()) | |
| o.state = StateChoice.ACTIVE |
There was a problem hiding this comment.
Keep in mind that message coming just after this for same instance logger.debug("[%s] Update instance %s:%s", namespace, provider, i.instance_id) . While I agree with idea to mention instance activation I would suggest different message :
logger.error("[%s] %s:%s instance which still exists has DELETED state in DB. Reactivating %s", namespace, provider, i.instance_id, i.all_time_fields())
asmorodskyi
force-pushed
the
updaterun_fixing
branch
2 times, most recently
from
bee5ce8 to
07147c7
Compare
Before this PR instance_id was unique in local DB. It appears that people creating same entities in different namespaces. This PR change DB structure and logic around it to be able to handle such flow. Also we extending logging of what actually got deleted.
asmorodskyi
force-pushed
the
updaterun_fixing
branch
from
07147c7 to
6ee2e8b
Compare
No description provided.