Set correct age for instance which was already exists before #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 80.67% 80.63% -0.05%
==========================================
Files 26 26
Lines 1972 1973 +1
==========================================
Hits 1591 1591
- Misses 381 382 +1
Continue to review full report at Codecov.
|
asmorodskyi
force-pushed
the
update_first_seen
branch
from
fdd2513 to
956af9a
Compare
ilausuch
approved these changes
Jul 22, 2022
| namespace, provider, i.instance_id, i.all_time_fields()) | ||
| logger.info("[%s] %s:%s instance which still exists has DELETED state in DB. Reactivating %s", | ||
| namespace, provider, i.instance_id, i.all_time_fields()) | ||
| o.first_seen = i.first_seen |
There was a problem hiding this comment.
Oh, yes, this solution is better. We are maintaining the DB consistent. Good idea.
There was a problem hiding this comment.
Nice catch!
Maybe we should do something like:
Delete and recreate or init all fields, so we do not get this situation just with a other field in the future!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.