Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dedicated folder for containers and add base image #350

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

asmorodskyi
Copy link
Collaborator

No description provided.

@asmorodskyi asmorodskyi changed the title TEMP Create dedicated folder for containers and add base image Feb 4, 2024
@asmorodskyi asmorodskyi force-pushed the containers branch 3 times, most recently from d9e49a3 to 592d3f3 Compare February 4, 2024 14:11
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8542270) 78.59% compared to head (1a3a716) 78.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files          22       22           
  Lines        1653     1653           
=======================================
  Hits         1299     1299           
  Misses        354      354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmorodskyi asmorodskyi force-pushed the containers branch 3 times, most recently from 8492548 to 575e8fc Compare February 4, 2024 18:15
m-dati
m-dati previously approved these changes Feb 5, 2024
Copy link
Collaborator

@m-dati m-dati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In files containers/Dockerfile and containers/Dockerfile_base there is a GH note on some error, probably not relevant.

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@asmorodskyi asmorodskyi merged commit 9b89665 into SUSE:master Feb 6, 2024
9 checks passed
@asmorodskyi asmorodskyi deleted the containers branch February 8, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants