Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selenium test #371

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

ricardobranco777
Copy link
Collaborator

@ricardobranco777 ricardobranco777 commented May 21, 2024

This PR fixes Selenium test for PCW:

  • Updates Selenium version.
  • Builds base image before building pcw itself.
  • Adds a sleep before creating user in database to allow for the migrations at startup to run.
  • Tidies up the Xpaths for the login & logout buttons.

@ricardobranco777 ricardobranco777 force-pushed the fix_selenium branch 2 times, most recently from 1c89c63 to 088b917 Compare May 21, 2024 15:24
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (8d96826) to head (8ec0cb6).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files          22       22           
  Lines        1676     1676           
=======================================
  Hits         1310     1310           
  Misses        366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mimi1vx
mimi1vx previously approved these changes May 21, 2024
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardobranco777 ricardobranco777 merged commit acc4ea1 into SUSE:master May 21, 2024
9 checks passed
@ricardobranco777 ricardobranco777 deleted the fix_selenium branch May 21, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants