Mute common error when deleting VPC #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorodskyi
force-pushed
the
csp_leftovers
branch
from
c9f42bc
to
b3ec48c
Compare
m-dati
approved these changes
Sep 17, 2024
ricardobranco777
approved these changes
Sep 17, 2024
| @@ -325,7 +325,12 @@ def vpc_can_be_deleted(self, resource_vpc, vpc_id) -> bool: | |||
|
|
|||
| def report_cleanup_results(self, vpc_errors: list, vpc_notify: list, vpc_locked: list) -> None: | |||
| if len(vpc_errors) > 0: | |||
There was a problem hiding this comment.
This if is redundant with the block below.
There was a problem hiding this comment.
agree with you but unfortunately I pressed merge button just before your comment popup 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 things :