Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Selenium test from codecov job #425

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ricardobranco777
Copy link
Collaborator

@ricardobranco777 ricardobranco777 commented Jan 30, 2025

make test runs the same pytest --cov that the codecov job runs as shown here & here

It just wastes CPU cycles and increases our carbon footprint for nothing.

Either we remove this or add SKIP_SELENIUM=1 to one of them, as this test takes a lot of time building a Docker image and then running Firefox for Selenium.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (d871823) to head (e9f5e2f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files          21       21           
  Lines        1632     1632           
=======================================
  Hits         1299     1299           
  Misses        333      333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardobranco777 ricardobranco777 changed the title Remove duplicate test Remove Selenium test from codecov job Jan 30, 2025
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asmorodskyi asmorodskyi merged commit 6b325c9 into SUSE:master Jan 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants