Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable aws native fencing #224

Merged
merged 1 commit into from
May 6, 2024
Merged

Enable aws native fencing #224

merged 1 commit into from
May 6, 2024

Conversation

BillAnastasiadis
Copy link
Collaborator

@BillAnastasiadis BillAnastasiadis commented May 3, 2024 •
edited
Loading

mpagot
mpagot reviewed May 6, 2024
View reviewed changes
ansible/playbooks/tasks/cluster-bootstrap.yaml
op stop interval=0 timeout=180
op monitor interval=120 timeout=60
meta target-role=Started
params tag={{ aws_stonith_tag}} pcmk_delay_max=15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
params tag={{ aws_stonith_tag}} pcmk_delay_max=15
params tag={{ aws_stonith_tag }} pcmk_delay_max=15

mpagot
mpagot reviewed May 6, 2024
View reviewed changes
terraform/aws/inventory.tmpl
aws_cluster_ip: ${virtual_ip}
aws_stonith_tag: ${stonith_tag}
aws_region: ${region}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to leave out region for the moment

mpagot
mpagot reviewed May 6, 2024
View reviewed changes
terraform/aws/outputs.tf
@@ -108,7 +108,8 @@ resource "local_file" "ansible_inventory" {
use_sbd = local.use_sbd,
routetable_id = aws_route_table.route-table.id,
virtual_ip = local.hana_cluster_vip,
stonith_tag = module.hana_node.stonith_tag
stonith_tag = module.hana_node.stonith_tag,
region = var.aws_region
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to leave out region for the moment

mpagot
mpagot approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillAnastasiadis BillAnastasiadis changed the title WIP: Enable aws native fencing Enable aws native fencing May 6, 2024
alvarocarvajald
alvarocarvajald approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpagot mpagot merged commit 2f1bca7 into SUSE:main May 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpagot mpagot mpagot approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillAnastasiadis @alvarocarvajald @mpagot