Qesap e2e verbosity tests #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpagot
commented
May 31, 2024
scripts/qesap/test/e2e/test.sh
Outdated
| if [ $rc -ne 0 ]; then | ||
| test_die "rc:$rc in verbose mode there should be some INFO" | ||
| fi | ||
| grep -E "TASK \[Say hello\]" "${QESAPROOT}/test_4_ansible_pass_verbose.txt" | wc -l |
There was a problem hiding this comment.
this test is intentionally left uncompleted. The expected value should be 1 but, due to a bug in the glue script that has to be fixed, is now 2
There was a problem hiding this comment.
I'll convert it to a real test in a next PR where I'll also at the same time fix the bug.
mpagot
commented
May 31, 2024
lpalovsky
approved these changes
May 31, 2024
mpagot
force-pushed
the
qesap_e2e_verbosity_tests
branch
3 times, most recently
from
57b4666 to
f2c10dc
Compare
mpagot
force-pushed
the
qesap_e2e_verbosity_tests
branch
from
f2c10dc to
c392cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce an improvement in e2e test of the glue script. In particular there are many new tests about the output of the qesap.py and for the first time the true execution of the ansible subcommand
Ticket : https://jira.suse.com/browse/TEAM-6844
VR is pipeline in PR