Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ansible log in case of failure #252

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

mpagot
Copy link
Collaborator

@mpagot mpagot commented Jul 1, 2024

Fix the issue.
Added two 2e2 tests that are currently failing showing an issue with the glue script behavior.
The .log.txt generated in case of failures are empty.

Ticket: https://jira.suse.com/browse/TEAM-9490

Verification

@mpagot mpagot changed the title Add e2e test to spot issue with log Fix issue with ansible log in case of failure Jul 5, 2024
Copy link
Collaborator

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpagot added 2 commits July 10, 2024 13:25
Change the implementation to behave more similarly in case of pass or
fail.
@mpagot mpagot force-pushed the subprocess_log_error branch from d7b9b3a to a5ab305 Compare July 10, 2024 12:49
@mpagot mpagot merged commit 3c4c970 into SUSE:main Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants