Use vm_size in AWS modules #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to use a uniform naming convention for modules across different cloud providers. This commit intentionally only change internal modules API and does not touch `terraform/aws/variables.tf`. In this way the end user has not to change anything in the conf.yaml. Remove some vm_size default at module level, only to have defaults in the upper layer and in a single place. Reorder variables fields always to have description at first place.
mpagot
force-pushed
the
tfvars_vm_type_module
branch
from
eeb87d9 to
321f426
Compare
mpagot
commented
Sep 3, 2024
| @@ -11,18 +11,27 @@ variable "resource_group_name" { | |||
| type = string | |||
| } | |||
|
|
|||
| variable "drbd_count" { | |||
There was a problem hiding this comment.
Just reorder variables making this file more similar to the AWS one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to use a uniform naming convention for modules across different cloud providers.
This PR intentionally only change internal modules API and does not touch
terraform/aws/variables.tf.In this way the end user has not to change anything in the conf.yaml.
Remove some vm_size default at module level, only to have defaults in the upper layer and in a single place.
Reorder variables fields always to have description at first place.
Ticket: https://jira.suse.com/browse/TEAM-7678
Verification
sle-15-SP6-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_6_BYOS-qesap_aws_r48xlarge_test@64bit
hana_instancetype = "r4.8xlarge"and it result in http://openqaworker15.qa.suse.cz/tests/296104/logfile?filename=deploy-terraform.plan.log.txt to havesle-15-SP6-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_6_BYOS-qesap_aws_r5bmetal_test@64bit
hana_instancetype = "r5b.metal"in http://openqaworker15.qa.suse.cz/tests/296105/file/configure-terraform.tfvars and the same used in http://openqaworker15.qa.suse.cz/tests/296105/logfile?filename=deploy-terraform.plan.log.txt