Remove vm_size default in Azure #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a no more used module used to generate ssh keys.
Align README and example, more salt removing. Order variables in similar order across modules and providers. Align inventory tremplate. Align terraform variable descriptions. Improve the .gitignore to better ignore venv and logs.
mpagot
force-pushed
the
tfvars_shuffle_more
branch
from
cd72eef to
78efc98
Compare
Remove default vm_size at module level in Azure. Keep variable order consistent across different modules.
mpagot
force-pushed
the
tfvars_shuffle_more
branch
from
78efc98 to
e8a58e0
Compare
|
LGTM, thanks |
|
LGTM. |
|
Too late, but you renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.suse.com/browse/TEAM-7678
Verification
Azure
sle-15-SP5-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_5_BYOS-qesap_azure_sapconf_test
AWS
sle-15-SP6-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_6_BYOS-qesap_aws_r48xlarge_test
sle-15-SP6-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_6_BYOS-qesap_aws_r58xlarge_test