Terraform gcp vm size internal variables #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes in this commit.
Change variable name in all module from machine_type to vm_size. Adapt accordingly the module main and the top level main. Add configurability for Monitor, the only one was missing a variable for the machine type. Remove all the default values for vm_size, at module level. This commit does not result in any API or functional change for the end user.
mpagot
force-pushed
the
terraform_gcp_vm_size
branch
from
aaa204b to
8a53c31
Compare
mpagot
commented
Sep 4, 2024
| variable "machine_type_monitor_server" { | ||
| description = "VM size for the monitor server machine" | ||
| type = string | ||
| default = "custom-1-2048" |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits PR: more details in the 2 commit messages
Ticket : https://jira.suse.com/browse/TEAM-7678
Verifications