Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename internal Ansible value #276

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Rename internal Ansible value #276

merged 1 commit into from
Oct 4, 2024

Conversation

mpagot
Copy link
Collaborator

@mpagot mpagot commented Oct 4, 2024 •
edited
Loading

Rename hana_resource_clone to hana_clone. Because resource is resource and clone is clone of that resource and because all others was named just clone w/o resource.

Code from Jan Kohoutek

Related to ticket : https://jira.suse.com/browse/TEAM-9426

Verifications

qesap regression

sle-15-SP6-Qesap-Azure-Payg-x86_64-BuildLATEST_AZURE_SLE15_6_PAYG-qesap_azure_saptune_test

sle-15-SP6-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_6_BYOS-qesap_aws_fencing_native_test

sle-15-SP5-Qesap-Gcp-Payg-x86_64-BuildLATEST_GCE_SLE15_5_PAYG-qesap_gcp_sapconf_test

HanaSR

jankohoutek
jankohoutek reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jankohoutek jankohoutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change order: to cluster_order:

jankohoutek
jankohoutek suggested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jankohoutek jankohoutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLS also change order: to cluster_order: as order is an internal Ansible variable

@mpagot
Rename internal Ansible value
a5d98d6 
Rename hana_resource_clone to hana_clone. Because resource is resource
and clone is clone of that resourcea nd because all others was named
just clone w/o resource.
@mpagot mpagot force-pushed the hana_resource_clone_2_hana_clone branch from 8e177b8 to a5d98d6 Compare October 4, 2024 07:38
jankohoutek
jankohoutek approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jankohoutek jankohoutek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you are about to change the rsc_SAPHana var in other MR

@mpagot
Copy link
Collaborator Author

mpagot commented Oct 4, 2024

LGTM, if you are about to change the rsc_SAPHana var in other MR

yes, other PR

jankohoutek
jankohoutek approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jankohoutek jankohoutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpalovsky
lpalovsky approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpagot mpagot merged commit 9b66598 into SUSE:main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpalovsky lpalovsky lpalovsky approved these changes

@jankohoutek jankohoutek jankohoutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpagot @jankohoutek @lpalovsky