[TEAM-9968] Cluster deployment SAPHanaSR-angi package in Public Clouds #307
Conversation
| @@ -40,6 +43,11 @@ | |||
| - name: Load SAP HANA variables | |||
| ansible.builtin.include_vars: ./vars/hana_vars.yaml | |||
|
|
|||
| - name: Re-set HANA Angi vars | |||
There was a problem hiding this comment.
Does this refer to line 24, right? Var name is the same but value has to be different in case of Angi? Do I correctly understand it?
There was a problem hiding this comment.
In this case, in a next PR, with the purpose of having one less task, we can try "conditional var definition".
Directly in var: section, on line 24
ms_saphanactl: "{% if use_hana_sr_angi | bool %}mst_SAPHanaCtl_{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_instance_number }}{% else %}msl_SAPHanaCtl_{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_instance_number }}{% endif %}"
| @@ -36,7 +43,7 @@ | |||
| state: present | |||
| replacefiles: true | |||
| when: | |||
| - ansible_facts['distribution_version'] == '15.1' | |||
| - ansible_facts['distribution_version'] == '15.1' and not use_hana_sr_angi | bool | |||
There was a problem hiding this comment.
Do we plan to have Angi ported to 15.1? If not we can remove this and and add a brand new assert task like (pseudocode):
died if use_hana_sr_angi and ansible_facts['distribution_version'] == '15.1'
There was a problem hiding this comment.
It's just sanitation.
There was a problem hiding this comment.
Do we plan to have Angi ported to 15.1?
No. Product is already out of support, so it will not get these packages.
| - name: Ensure SAPHanaSR hooks directory exists | ||
| ansible.builtin.file: | ||
| path: "{{ __hooks_dir }}" | ||
| owner: "{{ sap_hana_install_sid | lower }}adm" | ||
| group: sapsys | ||
| state: directory | ||
| mode: '0775' | ||
| when: not use_hana_sr_angi | bool | ||
|
|
||
| - name: Ensure SAPHanaSR-angi hooks directory exists | ||
| ansible.builtin.file: | ||
| path: "{{ __hooks_dir_angi }}" | ||
| owner: "{{ sap_hana_install_sid | lower }}adm" | ||
| group: sapsys | ||
| state: directory | ||
| mode: '0775' | ||
| when: use_hana_sr_angi | bool |
There was a problem hiding this comment.
is path the only parameter changing between the two?
| ansible.builtin.command: | ||
| cmd: crm configure property maintenance-mode=true | ||
| when: crm_maintainence_mode is false or crm_maintainence_mode == 'unknown' | ||
| cmd: crm maintenance on |
There was a problem hiding this comment.
seems an important change not related to Angi. Isn't it?
There was a problem hiding this comment.
This is correctly set of the maintenance mode, not forcing it to the configuratin file.
There was a problem hiding this comment.
And the correct value of maintenance-mode in configuration was changing along the versions of crm it's once 'on/off' then 'true/false' etc. This way is much safer.
There was a problem hiding this comment.
seems so important that can be in its own PR
| cmd: crm maintenance off | ||
| when: refreshed_crm_maintenance_mode is true or refreshed_crm_maintenance_mode == 'unknown' | ||
|
|
||
| # For debug purpose only |
There was a problem hiding this comment.
... and after changes are done, we shoud start cluster back to normal
There was a problem hiding this comment.
Is it name: Get cluster status at the end a debug task?
| @@ -23,21 +25,10 @@ | |||
| migration_threshold: "{{ (crm_conf_show.stdout | regex_search('migration-threshold=([0-9]*)', '\\1'))[0] }}" | |||
| changed_when: false | |||
|
|
|||
| - name: Create HANA topology resource | |||
| - name: Ensure maintenance mode is active | |||
There was a problem hiding this comment.
This one looks like important and not related to Angi.
There was a problem hiding this comment.
Topology is still there, just diff is confused.
There was a problem hiding this comment.
Seems like change is:
- call one more
crm maintenance onthat was missing - postpone
Create HANA topology resourcetask execution 4 tasks later
| when: cluster_order | length == 0 | ||
|
|
||
| - name: Ensure maintenance mode is off |
There was a problem hiding this comment.
Important change not related to Angi
TEAM-9968
SAPHanaSR-angi package cluster Public Cloud deployment
Verifiction runs:
https://openqaworker15.qa.suse.cz/tests/overview?version=15-SP5&build=%3Ajako_VR%3ASAPHanaSR-angi_PbC%3A15-SP5%3Atrue-angi&distri=sle
Notes: Azure oQA job doesn't finish, but fail is unrelated to the deployment
https://openqaworker15.qa.suse.cz/tests/overview?build=%3Ajako_VR%3ASAPHanaSR-angi_PbC%3A15-SP5%3Ano-angi&version=15-SP5&distri=sle