Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testsuite with sqlite3 #1081

Merged
merged 10 commits into from
Feb 12, 2024
Merged

Fix testsuite with sqlite3 #1081

merged 10 commits into from
Feb 12, 2024

Conversation

digitaltom
Copy link
Member

Description

Please describe your change and provide as much context as possible.

Fixes # (issue)

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have verified that my code follows RMT's coding standards with rubocop.
  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • RMT's test coverage remains at 100%.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.

lcaparroz and others added 3 commits February 1, 2024 16:03
When running tests, the `yield and return if *` statement seems to not
be working properly; even when the condition is true, it would not
return.
Copy link
Member

@lcaparroz lcaparroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SUSE SUSE deleted a comment from suse-tests-fail Feb 7, 2024
@digitaltom digitaltom merged commit e4ee2f3 into master Feb 12, 2024
3 checks passed
@digitaltom digitaltom deleted the fix_testsuite_sqlite branch February 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants