Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require go.12 in module #237

Closed
wants to merge 1 commit into from
Closed

Require go.12 in module #237

wants to merge 1 commit into from

Conversation

MalloZup
Copy link
Contributor

@MalloZup MalloZup commented May 21, 2019

avoid checksum errors that could be present and require minimal golang
version for fixing it. see (golang/go#29278)

IF we don't have this we will have some issues with the go.sum checksum

info:

On the OBS side, i dunno if this can cause issue I don' think

avoid checksum errors that could be present and require minimal golang
version see (golang/go#29278)
@jordimassaguerpla
Copy link
Member

@MalloZup Could you check which go version is used to build caaspctl in Devel:CaaSP:4.0 and SUSE:SLE-15-SP1:U:P:CASP40? You can use the "osc buildinfo" command with the caaspctl package checkout.

If we use go1.12, I am fine with this change.

@nirmoy
Copy link
Contributor

nirmoy commented May 21, 2019

nirmoy@chapman:~/devel/cilium/home:ndas:branches:Devel:CaaSP:4.0/caaspctl> osc buildinfo|grep go1
  <bdep name="go1.11" version="1.11.9" release="1.12.1" arch="x86_64" project="SUSE:SLE-15:Update" repository="standard" />
nirmoy@chapman:~/devel/cilium/home:ndas:branches:Devel:CaaSP:4.0/caaspctl> 

@MalloZup
Copy link
Contributor Author

I think we have 2 solution. This would be the cleanest one but I'm not sure how it can impact the pkg (obs, ci and openSUSE leap pkg). 2nd solution could be to remove go sum and put it to gitignore. It might be the less impact solution

@saschagrunert
Copy link
Contributor

Sorry for jumping in here but @MalloZup requested my review. The change LGTM, but I would recommend to check your imports. For example the commit d687e77c8ae9 of the staging repository k8s.io/api seems to come from the master branch and not from the release-1.14 branch.

I think it would be cool to have a module validation as Makefile target, like this:
https://github.com/cri-o/cri-o/blob/b76dad9fd460699f31f9ca7de82d775eb1f1e3ec/Makefile#L210-L214

Copy link
Member

@jordimassaguerpla jordimassaguerpla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked. So we have go1.12 because we use that for k8s. However, caaspctl is pulling go1.11, so we could use go1.12 but you need to adapt the spec file to make sure we pull go1.12

@jordimassaguerpla
Copy link
Member

jordimassaguerpla commented May 21, 2019

I just checked. So we have go1.12 because we use that for k8s. However, caaspctl is pulling go1.11, so we could use go1.12 but you need to adapt the spec file to make sure we pull go1.12

You most probably will have to change this https://github.com/SUSE/caaspctl/blob/master/ci/packaging/suse/caaspctl_spec_template#L30

@MalloZup
Copy link
Contributor Author

I think this ISSUE require some thinking And discussion. For the moment i will try to don't solve the problem.

Creating an issue we can think later and closing this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants