Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set default_statistics_target (bsc#1022286) #18

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Conversation

mantel
Copy link
Contributor

@mantel mantel commented Aug 14, 2017

No description provided.

@mantel mantel requested a review from isbm August 14, 2017 14:21
Copy link
Member

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this remove the value of the value is Set to 10? If yes, do we want to reset this always if the customer want its own value?

@mantel
Copy link
Contributor Author

mantel commented Aug 15, 2017

I do not know if this will remove a value that has already been set. But no longer setting it via smdba is the right thing in any case. Default value is 100 and we are setting it to 10 which is definitely too low. So IMHO the change to smdba should happen in any case. What to do with existing installations is another question.

@mantel mantel merged commit 5df748d into master Aug 15, 2017
@mantel mantel deleted the master-analyze branch August 15, 2017 09:36
@mantel
Copy link
Contributor Author

mantel commented Aug 15, 2017

I just tested on an existing installation. After removing the parameter from the postgresql.conf and restarting the service, value is set to default:

postgres@e115:~> psql
psql (9.6.3)
Type "help" for help.

postgres=# show default_statistics_target;
default_statistics_target

100
(1 row)

postgres=#

So only question left is if we need to execute an analyzer run or if this will happen automatically in the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants