Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update autotuning #19

Merged
merged 5 commits into from
Aug 21, 2017
Merged

update autotuning #19

merged 5 commits into from
Aug 21, 2017

Conversation

mcalmer
Copy link
Member

@mcalmer mcalmer commented Aug 20, 2017

Some changes to autotuning:

  • allow 270 connections while the default still stay with 400
  • reset default_statistic_target if the value is lower than 10
  • fix compare operations
  • write help for specifying max_connections

@mcalmer
differ between minimal required connections and our default connections
7c2dcc9 
The minimal required connections are calculated with 270 for the
current default setting of apach, tomcat, etc in SUSE.

We just define a higher default of 400 but we should give a customer
the opportunity to choose a lower value and have more memory per
connection.
@mcalmer
use default value for default_statistics_target if configured value i…
93c258d 
…s too small (bsc#1022286)
@mcalmer
use integer values when doing a greater than / lower than comparison
7cd9a43
@mcalmer
add help for defining max_connections
a31dfb0
@mcalmer mcalmer requested review from isbm and mantel August 20, 2017 17:22
mantel
mantel reviewed Aug 21, 2017
View reviewed changes
Copy link
Contributor

@mantel mantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks good. Let's see what BOFH says...

@mantel
Copy link
Contributor

mantel commented Aug 21, 2017

If we merge this request we must not forget to bump the version number. For smdba this does not happen automagically.

@mantel mantel merged commit 4698169 into master Aug 21, 2017
@mantel mantel deleted the mc-update-autotuning branch August 21, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantel mantel mantel left review comments

@isbm isbm Awaiting requested review from isbm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcalmer @mantel